Always open browser from systray (#2418)

stashapp · Mar 24, 2022 · 23c4642 · 23c4642
1 parent ba41133
commit 23c4642
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/internal/desktop/systray_nonlinux.go b/internal/desktop/systray_nonlinux.go
@@ -63,9 +63,7 @@ func systrayInitialize(shutdownHandler ShutdownHandler, faviconProvider FaviconP
 					if item == "markers" {
 						item = "scenes/markers"
 					}
-					if c.GetNoBrowser() {
-						openURLInBrowser(item)
-					}
+					openURLInBrowser(item)
 				}
 			}(item)
 		}
@@ -83,9 +81,7 @@ func systrayInitialize(shutdownHandler ShutdownHandler, faviconProvider FaviconP
 		for {
 			select {
 			case <-openStashButton.ClickedCh:
-				if !c.GetNoBrowser() {
-					openURLInBrowser("")
-				}
+				openURLInBrowser("")
 			case <-quitStashButton.ClickedCh:
 				systray.Quit()
 				shutdownHandler.Shutdown(0)

diff --git a/ui/v2.5/src/components/Changelog/versions/v0140.md b/ui/v2.5/src/components/Changelog/versions/v0140.md
@@ -8,6 +8,7 @@
 * Improved autotag performance. ([#2368](https://github.com/stashapp/stash/pull/2368))
 
 ### 🐛 Bug fixes
+* Fix Open Stash systray menu item not opening stash when Skip Opening Browser was enabled. ([#2418](https://github.com/stashapp/stash/pull/2418))
 * Fix error saving a scene from the tagger when the scene has stash ids. ([#2408](https://github.com/stashapp/stash/pull/2408))
 * Perform tag pattern exclusion on stash-box sources. ([#2391](https://github.com/stashapp/stash/pull/2391))
 * Don't generate jpg thumbnails for animated webp files. ([#2388](https://github.com/stashapp/stash/pull/2388))