Skip to content

Commit

Permalink
Remove unnecessary truncation in tables
Browse files Browse the repository at this point in the history
IMO there is no need to truncate the title in the scenes table and the
name in the performers table. This because both tables also contain an
image which means that multiple lines should be possible without really
extending the height of the row. Furthermore both tables contain other
values which might be way longer and also aren't wrapped (like tags and
performers for scenes, and aliases for performers).
  • Loading branch information
gitgiggety committed Aug 25, 2021
1 parent d48bfac commit cbb9d50
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
6 changes: 2 additions & 4 deletions ui/v2.5/src/components/Performers/PerformerListTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import React from "react";
import { Button, Table } from "react-bootstrap";
import { Link } from "react-router-dom";
import * as GQL from "src/core/generated-graphql";
import { Icon, TruncatedText } from "src/components/Shared";
import { Icon } from "src/components/Shared";
import { NavUtils } from "src/utils";

interface IPerformerListTableProps {
Expand All @@ -27,9 +27,7 @@ export const PerformerListTable: React.FC<IPerformerListTableProps> = (
</td>
<td className="text-left">
<Link to={`/performers/${performer.id}`}>
<h5>
<TruncatedText text={performer.name} />
</h5>
<h5>{performer.name}</h5>
</Link>
</td>
<td>{performer.aliases ? performer.aliases : ""}</td>
Expand Down
8 changes: 2 additions & 6 deletions ui/v2.5/src/components/Scenes/SceneListTable.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { Table, Button, Form } from "react-bootstrap";
import { Link } from "react-router-dom";
import * as GQL from "src/core/generated-graphql";
import { NavUtils, TextUtils } from "src/utils";
import { Icon, TruncatedText } from "src/components/Shared";
import { Icon } from "src/components/Shared";
import { FormattedMessage } from "react-intl";

interface ISceneListTableProps {
Expand Down Expand Up @@ -80,11 +80,7 @@ export const SceneListTable: React.FC<ISceneListTableProps> = (
</td>
<td className="text-left">
<Link to={sceneLink}>
<h5>
<TruncatedText
text={scene.title ?? TextUtils.fileNameFromPath(scene.path)}
/>
</h5>
<h5>{scene.title ?? TextUtils.fileNameFromPath(scene.path)}</h5>
</Link>
</td>
<td>{scene.rating ? scene.rating : ""}</td>
Expand Down

0 comments on commit cbb9d50

Please sign in to comment.