Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DLNA port configurable #4760

Closed
Conkuist opened this issue Apr 14, 2024 · 3 comments · Fixed by #4836
Closed

Make DLNA port configurable #4760

Conkuist opened this issue Apr 14, 2024 · 3 comments · Fixed by #4836

Comments

@Conkuist
Copy link

Is your feature request related to a problem? Please describe.
XBVR DLNA Server can't run at the same time as Stash DLNA Server because both use the same port 1338

Describe the solution you'd like
Do not use the default port or make the port configurable
https://github.com/stashapp/stash/blob/develop/internal/dlna/service.go#L141

Describe alternatives you've considered
I tried to figure out how to change it myself inside the docker container but was unable to get it done.

Additional context
I run XBVR and Stash in Docker

@ipedrazas
Copy link
Contributor

You cannot receive external multicast inside of a container (unless the network is set to host). These two issues explain the problem:

moby/moby#23659
moby/libnetwork#2397

Making the port configurable would allow to run the container using network_mode: host

@Conkuist
Copy link
Author

Conkuist commented May 9, 2024

DLNA only works when the network mode is set to host. This is true for XBVR and Stash. Both use the same port and none of them offer a way to change it. Which is the reason why I made the request to make it configurable.

ipedrazas added a commit to ipedrazas/stash that referenced this issue May 14, 2024
Signed-off-by: Ivan Pedrazas <ipedrazas@gmail.com>
@ipedrazas
Copy link
Contributor

I've created a PR #4836 to enable the DLNA port conf from the config.yml file

@DogmaDragon DogmaDragon linked a pull request May 15, 2024 that will close this issue
@WithoutPants WithoutPants added this to the Version 0.26.0 milestone May 16, 2024
@WithoutPants WithoutPants moved this to In review in Roadmap May 16, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in Roadmap May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants