Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip file extension from scene title when scanning #1022

Merged
merged 5 commits into from
Jan 7, 2021

Conversation

bnkai
Copy link
Collaborator

@bnkai bnkai commented Dec 25, 2020

No description provided.

@WithoutPants
Copy link
Collaborator

I don't really like this as default, uncontrolled behaviour. File extensions can be stripped post-scan using the filename parser. When imported, the filename is its only identity until it is otherwise renamed, and the extension is part of that identity. At the very least, this should be configurable behaviour.

@bnkai
Copy link
Collaborator Author

bnkai commented Jan 5, 2021

Agreed on default , added it as optional in the UI (false by default)

For my use case (and maybe a few users from the discord channel) the extension part of the filename was not needed and a thing i had to remove after every scan. Going evey time to the filename parser only for this part wasnt optimal for me ( i even made a script to batch remove extensions from the db for this reason). Having a properly named scene in many cases and having the extension to remove was too bothersome. If i ever needed to check the file extension (or something else in the original filename) the file path was still there so no need for the extension to be part of the title (again for my use case).

@WithoutPants WithoutPants added this to the Version 0.5.0 milestone Jan 7, 2021
@WithoutPants WithoutPants added the improvement Something needed tweaking. label Jan 7, 2021
@WithoutPants WithoutPants merged commit 1882b44 into stashapp:develop Jan 7, 2021
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants