Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery view persistence #1105

Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2021

Adds display persistence to the gallery view by adding a VIEW persistence mode which only reads and writes the displayMode, but leaves the rest of the persisted state intact.

Also changes the gallery filter to only show folder name if the gallery doesn't have a title, rather than the entire path. This matches how we now display it elsewhere.

@WithoutPants
Copy link
Collaborator

I don't really feel that this is a good fix for what I imagine is the original issue (gallery images view state is not persisted), since setting the view in the gallery images view overwrites the view in the top-level Images view. Gallery images view should have its own entry in the view state.

@ghost
Copy link
Author

ghost commented Feb 28, 2021

I've added a prop to set a custom key for the gallery images so they're stored separately from the main image view. There's no getting around the need for a limited state persistance however, since sublists don't display the same datasets, so persisting filters and pagination would lead to empty pages.

@WithoutPants WithoutPants merged commit 01da280 into stashapp:develop Mar 1, 2021
@WithoutPants WithoutPants added this to the Version 0.6.0 milestone Mar 1, 2021
@WithoutPants WithoutPants added the improvement Something needed tweaking. label Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant