Whitespace is not trimmed from the end of query strings #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should trim the query string on the backend as well so any scripts/external apps don't run into the same issue. Also, filtering out zero length clauses, which is presumably what happens when there are multiple sequential spaces in the middle of the query. |
|
sure, I added a fix to trim it on backend too |
WithoutPants
requested changes
Apr 8, 2021
bnkai
reviewed
Apr 11, 2021
bnkai
reviewed
Apr 11, 2021
ghost
requested a review
from 
WithoutPants
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a trim on the query strings so now it doesn't returns all the search if there are one or more space at the end of query.
Resolves #1260