Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Auto scroll user back to the top when page navigation is clicked #1270

Merged
merged 3 commits into from Apr 9, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Apr 5, 2021

When clicking on any of the following (First, Previous, , Next or Last) auto scroll the user back to the top of the page.
Resolves #1267

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 9, 2021
@WithoutPants WithoutPants added this to the Version 0.7.0 milestone Apr 9, 2021
@WithoutPants WithoutPants merged commit d042ec4 into stashapp:develop Apr 9, 2021
@GsMumbo
Copy link

GsMumbo commented May 5, 2021

I’ve noticed that an unintended side effect of this is that it scrolls you back to the top when using the browser’s back button. For example if I’m going down a gallery and rating each image one by one, every time I click back I get pulled to the top of the page again. That means I have to scroll back to where I was every single time.

Is there a way to limit this to only trigger when you use the page buttons, and to exclude it when you use your browser’s forward and back buttons?

@ghost ghost deleted the auto-scroll-user-top-pagination branch May 9, 2021 10:23
@WithoutPants
Copy link
Collaborator

I’ve noticed that an unintended side effect of this is that it scrolls you back to the top when using the browser’s back button. For example if I’m going down a gallery and rating each image one by one, every time I click back I get pulled to the top of the page again. That means I have to scroll back to where I was every single time.

I can confirm that the issue you describe is not caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Auto scroll user back to the top when page number/page navigation is clicked
2 participants