Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added details, deathdate, hair color, weight to performers and added details to studios #1274

Merged
merged 13 commits into from Apr 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2021

I added a new column details on the table performers and studios.
I also changed the scrapper freeones to get the bio from the freeones's website.
I added it on is missing filter.
Resolves #811
Resolves #712
Resolves #545

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 8, 2021
@WithoutPants WithoutPants added this to the Version 0.7.0 milestone Apr 8, 2021
@WithoutPants
Copy link
Collaborator

Since it's doing a schema update for performers, perhaps consider including the following:

@jeremymeyers
Copy link
Collaborator

If we include Weight we should include Hair Color.

@WithoutPants
Copy link
Collaborator

If we include Weight we should include Hair Color.

Agree. Didn't see that in the github issues, but it is commonly asked for.

@ghost
Copy link
Author

ghost commented Apr 9, 2021

Are you as well included rating into performers's table as well?

@WithoutPants
Copy link
Collaborator

No. Rating needs more changes outside the basics, so should be raised as a separate PR.

@ghost
Copy link
Author

ghost commented Apr 9, 2021

Ok it is all done, I added deathdate, hair color and weight to performers. But one question before pushing, do you want me to add a filter death year into performers filters?

@WithoutPants
Copy link
Collaborator

Yes, filter criteria should be added for death date, hair colour and weight.

@ghost
Copy link
Author

ghost commented Apr 10, 2021

ok so I added deathdate, weight and hair color to performers, and even on filters.
I changed freeone's scraper to download the new data.

@ghost ghost changed the title added details to performers and studios added details, deathdate, hair color, weight to performers and added details to studios Apr 10, 2021
@bnkai
Copy link
Collaborator

bnkai commented Apr 10, 2021

There is currently no validation for the age. Could we add a simple one to make sure death_date > birthdate for the age display?

@ghost
Copy link
Author

ghost commented Apr 12, 2021

I added a validation for the date. And I added some tests.

Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weight field requires more design decisions. I'm not sure it's worth including in this PR.

graphql/documents/data/performer.graphql Outdated Show resolved Hide resolved
graphql/schema/types/performer.graphql Outdated Show resolved Hide resolved
pkg/api/resolver_mutation_performer.go Outdated Show resolved Hide resolved
pkg/api/resolver_mutation_performer.go Outdated Show resolved Hide resolved
pkg/api/resolver_mutation_performer.go Outdated Show resolved Hide resolved
@ghost ghost requested a review from WithoutPants April 15, 2021 15:34
@WithoutPants WithoutPants merged commit d673c4c into stashapp:develop Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
3 participants