-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added details, deathdate, hair color, weight to performers and added details to studios #1274
Conversation
Since it's doing a schema update for performers, perhaps consider including the following:
|
If we include Weight we should include Hair Color. |
Agree. Didn't see that in the github issues, but it is commonly asked for. |
Are you as well included rating into performers's table as well? |
No. Rating needs more changes outside the basics, so should be raised as a separate PR. |
Ok it is all done, I added deathdate, hair color and weight to performers. But one question before pushing, do you want me to add a filter death year into performers filters? |
Yes, filter criteria should be added for death date, hair colour and weight. |
ok so I added deathdate, weight and hair color to performers, and even on filters. |
There is currently no validation for the age. Could we add a simple one to make sure death_date > birthdate for the age display? |
I added a validation for the date. And I added some tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The weight field requires more design decisions. I'm not sure it's worth including in this PR.
I added a new column details on the table performers and studios.
I also changed the scrapper freeones to get the bio from the freeones's website.
I added it on is missing filter.
Resolves #811
Resolves #712
Resolves #545