Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in-memory screenshot generation for sprites and phash #1316

Merged
merged 5 commits into from
May 5, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 16, 2021

Skips writing/reading to disk by encoding to bmp and routing the output to stdout. No performance difference over internal nvme storage, but quite a bit faster than nas storage. Somewhat simpler as well.

bnkai
bnkai previously approved these changes Apr 17, 2021
@bnkai bnkai dismissed their stale review April 19, 2021 16:51

info from user in discord channel

@bnkai
Copy link
Collaborator

bnkai commented Apr 19, 2021

Update from the discord channel.
Using the build from this PR seemed to hang the generate process. The specific user used it for sprite generation
The info from the files it stopped/hang at doesnt show anything obvious (filenames reducted from ffprobe report)
message.txt
message(1).txt
Switching back to current dev he was able to continue generating past those files

Edit:
Tested a few times after merging with develop first, i can't seem to reproduce the above issue.

@ghost
Copy link
Author

ghost commented Apr 28, 2021

Update from the discord channel.
Using the build from this PR seemed to hang the generate process. The specific user used it for sprite generation
The info from the files it stopped/hang at doesnt show anything obvious (filenames reducted from ffprobe report)

I managed to reproduce. The way we were reading out stdout/stderr was susceptible to stalls when the buffers filled up too quickly. I tore out the code and just let os/exec handle it, which seems to work fine. I'll run a phash rebuild overnight to make sure there's no more stalls.

EDIT: No stalls when regenerating phash for all my scenes.

@WithoutPants WithoutPants added this to the Version 0.7.0 milestone May 5, 2021
@WithoutPants WithoutPants added the improvement Something needed tweaking. label May 5, 2021
@WithoutPants WithoutPants merged commit 31981d4 into stashapp:develop May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants