Revert always show preview videos on small devices #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems to work ok. Tested in desktop and an android smartphone. |
bnkai
approved these changes
May 2, 2021
kermieisinthehouse
added a commit
to kermieisinthehouse/stash
that referenced
this pull request
Aug 14, 2021
kermieisinthehouse
added a commit
to kermieisinthehouse/stash
that referenced
this pull request
Aug 14, 2021
kermieisinthehouse
added a commit
to kermieisinthehouse/stash
that referenced
this pull request
Aug 18, 2021
kermieisinthehouse
added a commit
to kermieisinthehouse/stash
that referenced
this pull request
Aug 23, 2021
kermieisinthehouse
added a commit
to kermieisinthehouse/stash
that referenced
this pull request
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverted change from #1104 which automatically showed preview videos on small devices. This had the unintended effect of playing everything on iPad devices.
I considered auto-previewing on very small width devices, but given that sounds of these videos may also play depending on the settings, I think it's better to have this as a user-directed action.
Note that with this fix, I still had issues when testing on iPad where preview videos would not show correctly if they were rendered off-screen (ie you had to scroll to show the card). I've been unable to fix this issue, but I don't think it was introduced by this change.
Fixes #1281