Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotag support for images and galleries #1345

Merged
merged 9 commits into from
May 3, 2021

Conversation

WithoutPants
Copy link
Collaborator

  • Adds compound filters (AND, NOT, OR) for image and gallery queries. Refactored the queryBuilders for these accordingly.
  • Adds autotag functionality for images and galleries.

Note that images in zips may not tag correctly when autotagging from performer/studio/tag due to the way that regex interacts with the null character in the image paths. This will be addressed when the character for zip paths is changed at a later date.

Resolves #977

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 27, 2021
@WithoutPants WithoutPants added this to the Version 0.7.0 milestone Apr 27, 2021
@bnkai
Copy link
Collaborator

bnkai commented Apr 28, 2021

A join with the images table for the gallery queries seems to have been removed

Error executing find query with SQL: SELECT DISTINCT galleries.id FROM galleries GROUP BY galleries.id ORDER BY COUNT(distinct images.id) ASC LIMIT 40 OFFSET 0 , args: [], error: no such column: images.id

This makes the AVG Resolution filter and the sort by Images Count to fail in the Galleries page.

pkg/models/model_image.go Outdated Show resolved Hide resolved
@WithoutPants WithoutPants requested a review from bnkai April 29, 2021 00:06
@WithoutPants WithoutPants merged commit a360907 into stashapp:develop May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Auto-tagging does not import tags from images or galleries
2 participants