UI filter refactor #1406
Merged
UI filter refactor #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitgiggety
reviewed
May 22, 2021
gitgiggety
reviewed
May 23, 2021
|
Good pickups, thanks! |
ghost
reviewed
May 25, 2021
bnkai
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant refactor of the UI filter code. The purpose is to try to reduce boilerplate and make it easier to add new filter criteria.
Included are the following changes:
en-GBis formalised as the default language, meaning that it will display fromen-GB.jsonif the message ID is not found in the chosen language.en-US.jsonshould now only contain overrides to values inen-GB.json. I've added aREADMEfile to document this. The json files are now sorted alphabetically as well.