Rebuild Studio page by splitting view and edit #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitgiggety
commented
Aug 11, 2021
| value={studio.parent_studio?.name} | ||
| url={`/studios/${studio.parent_studio?.id}`} | ||
| trusted |
There was a problem hiding this comment.
I believe these could/should be applied in more places then. Movies for one also uses URLField for studio and thus also opens a new tab, and applies noopener noreferrer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says :) Refactor the
Studiocomponent into aStudioDetailsPaneland aStudioEditComponentcomponent just like all other of these pages.After this refactor links are used for both the URL field as the parent studio which where previously not available as the read-only form field was shown. Furthermore it allows for expanding the features like implementing #1625.