Rebuild gallery edit using formik #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitgiggety
force-pushed
the
gallery-formik
branch
from
63725e5
to
393ff8c
Compare
* Prompt on page leave when changes are not saved * Fixes missing required validation * Only enables save when changes are made * Wrap in <Form onSubmit> (not sure if this does anything)
gitgiggety
force-pushed
the
gallery-formik
branch
from
393ff8c
to
f286c1f
Compare
WithoutPants
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope I didn't break anything related to stashbox :)
Found one smallish issue, but this exists for scenes as well. If you make edits but don't save, and afterwards use delete, the "Unsaved changes. Are you sure you want to leave?" confirmation is shown. This obviously because after the delete the page is redirected, while the form is also "dirty" which thus triggers the notification. But I'm unsure how to fix this, so suggestions welcome (or just merge because the same issue exists in other places as well :))