Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scene edit panel layout #1737

Merged
merged 4 commits into from
Sep 19, 2021
Merged

Fix scene edit panel layout #1737

merged 4 commits into from
Sep 19, 2021

Conversation

liquid-flow
Copy link
Contributor

Scope

UI: SceneEditPanel

This PR fixes the layout on 320 and 1024 viewports (labels for Galleries, Studios, Movies/Scenes)

How to test

  1. Run the UI
  2. Navigate to any scene, click the Edit tab
  3. Check that the layout is consistent on the following breakpoints: 320, 576, 768, 1024, 1200

Screenshots

320px

Before After
before-320 after-320

1024px

Before After
before-1024 after-1024

@liquid-flow liquid-flow marked this pull request as ready for review September 17, 2021 06:05
WithoutPants
WithoutPants approved these changes Sep 19, 2021
View reviewed changes
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hadn't tested on 320px width viewports.

FYI, changelog entries are added at the top of the list, I've amended the changelog to this effect.

@WithoutPants WithoutPants merged commit 13fda2a into stashapp:develop Sep 19, 2021
@WithoutPants WithoutPants added this to the Version 0.10.0 milestone Sep 19, 2021
@liquid-flow liquid-flow deleted the fix-scene-edit-panel-layout branch September 19, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WithoutPants WithoutPants WithoutPants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@liquid-flow @WithoutPants