Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie card visual consistency #1758

Merged
merged 5 commits into from
Sep 26, 2021
Merged

Conversation

gitgiggety
Copy link
Contributor

Style the movie card the same as the scene card.

  • Show date
  • Show synopsis
  • Move scene count to "button" which shows the scene names on hover
  • Show scene number / index as "button"

Fixes: #1638

* Add date
* Add synopsis
* Show scene count with hover listing the scenes
* Move scene index to button
@WithoutPants
Copy link
Collaborator

Here is what a Movie card now looks like in the Movies page:
image

When viewed from a scene, it looks like this (scene index is 1):
image

I think the scene index display is not intuitive at all. It's not clear to me that that number is the scene number in the movie. I think a variation on the original display should probably be used. I had a quick crack, but it probably could be better:

image

@gitgiggety
Copy link
Contributor Author

The scene number / index obviously was a "hack" and I didn't know how to properly show it either. Adding it as just a Scene #x is a possibility as well .

But I myself don't use / have any movies in Stash, so I don't really care how it's shown :) So let me know how you want it to look and I'll change it. (Or if you've got the time or want to try it yourself, just change it).

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Sep 26, 2021
@WithoutPants WithoutPants added this to the Version 0.10.0 milestone Sep 26, 2021
@WithoutPants WithoutPants merged commit 1d04b55 into stashapp:develop Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Movie gridview cosmetic consistency
2 participants