Add clear button to list filter search input #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutPants
requested changes
Oct 14, 2021
There was a problem hiding this comment.
- The x button should only be visible if there is text entered in the text field.
- Add a className to the button so that it can be manipulated with css.
- The button probably needs some styling work on it. The colour needs to be more subtle and it probably should change background colour on hover. It stands out a lot in the current version.
Comment on lines
228
to
235
| <OverlayTrigger | ||
| placement="top" | ||
| overlay={ | ||
| <Tooltip id="filter-tooltip"> | ||
| <FormattedMessage id="actions.clear" /> | ||
| </Tooltip> | ||
| } | ||
| > |
There was a problem hiding this comment.
I don't think an overlay is necessary for this. A title on the button should be sufficient.
|
|
kermieisinthehouse
approved these changes
Oct 14, 2021
kermieisinthehouse
added
improvement
WithoutPants
requested changes
Oct 15, 2021
| <Button | ||
| variant="secondary" | ||
| onClick={onClearQuery} | ||
| title={intl.formatMessage({ id: "actions.search" })} |
There was a problem hiding this comment.
This should be actions.clear.
WithoutPants
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1306 but only for the ListFilter component.
Closes #1306