Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks page refactor #1949

Merged
merged 18 commits into from
Nov 23, 2021
Merged

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Nov 3, 2021

Resolves #908

Moves the Scan, Generate and Clean tasks behind dialogs and reorders the tasks page:

image
image
image
image
image

Folder selection is integrated in the dialogs if the selective method was available prior.

Note that the preview generation settings and the overwrite flag have been rolled into the generate dialog so that they are available both on the tasks page and from scene selection.

Todo:

  • save defaults for all tasks

The following should be implemented after this PR is merged:

@WithoutPants WithoutPants added improvement Something needed tweaking. ui Issues related to UI labels Nov 3, 2021
@WithoutPants WithoutPants added this to the Version 0.12.0 milestone Nov 4, 2021
@WithoutPants
Copy link
Collaborator Author

Restyled based on feedback.

image

Tasks with a separate ellipsis button will run the task using the default settings if the main button is clicked, and will open the dialog if the ellipsis button is clicked. Where there is no defaults set in the configuration, the dialog will open regardless of which button is clicked. A toast message now appears saving defaults indicating that the default settings will be used when clicking the main button.

Added default setting support for scan, auto tag and generate tasks.

@WithoutPants
Copy link
Collaborator Author

Reverted most of the re-styling changes. Separated ellipsis buttons remain, as well as grouping the tasks.

image

@bnkai
Copy link
Collaborator

bnkai commented Nov 22, 2021

  • The default settings while being saved correctly in the config file dont seem to get passed back to the UI.
    For example using the scan
    01
    Select some options and save
    02
    Close the dialog and reopen and you get the first image again

  • The paths for the selective scan are not sent to the backend

@WithoutPants
Copy link
Collaborator Author

Bloody config refactor biting me again. Should be fixed now.

@bnkai
Copy link
Collaborator

bnkai commented Nov 22, 2021

  • The
    The paths for the selective scan are not sent to the backend
    issue is still present.
    Click on a scan/autotag task for example. Select and add a small subdirectory. Click scan/autotag/.... The scanning/taggins goes through all files since the paths are not sent via the graphql request even though they are displayed in the UI dialog

  • The default config settings now work ok

  • Another minor UI issue
    If you untick something in the autotag dialog
    notclickable
    You can't tick it back

@WithoutPants
Copy link
Collaborator Author

Sorry, didn't read the entire list. The other issues should now be addressed.

@WithoutPants WithoutPants merged commit ff32f22 into stashapp:develop Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking. ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Scan options should be persisted
2 participants