Add forward seeking buttons to jwplayer #1973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermieisinthehouse
added
feature
|
This un-centered the controls on mobile, shifting them to the top left corner. You can actually see the effect in the image in the top post. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this feature is missing from jwplayer, but someone posted a jQuery-based workaround in the jwplayer bug tracker and I've ported it to vanilla js/typescript. (c.f. jwplayer/jwplayer#3894)
This has a little quirk: because it's mirroring the rewind button it's also mirroring the
10which looks a little odd.On the pro side: it adds a feature I badly want and keeps this PR simple and self contained because no additional asset needs to be added (that would possibly violate copyrights if we took the original icon and edited it)
Hopefully it's added to jwplayer upstream at some point.