Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marker previews should respect preview audio setting #2101

Merged
merged 3 commits into from
Dec 13, 2021
Merged

Marker previews should respect preview audio setting #2101

merged 3 commits into from
Dec 13, 2021

Conversation

kermieisinthehouse
Copy link
Collaborator

Fixes #2056

@kermieisinthehouse kermieisinthehouse added the improvement Something needed tweaking. label Dec 9, 2021
@kermieisinthehouse kermieisinthehouse added this to the Version 0.12.0 milestone Dec 9, 2021
@bnkai
Copy link
Collaborator

bnkai commented Dec 11, 2021

Looks and works ok.
Should the include_audio_desc text (Includes audio stream when generating previews.) be updated to include markers ?

@kermieisinthehouse
Copy link
Collaborator Author

Eh, the marker videos are just previews themselves. The actual marker when you click it plays with audio. I think the existing language is fine

@WithoutPants WithoutPants merged commit 9a8f05d into stashapp:develop Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnkai bnkai bnkai approved these changes

Assignees
No one assigned
Labels
improvement Something needed tweaking.
Projects
None yet
Milestone
Version 0.12.0
Development

Successfully merging this pull request may close these issues.

[Feature] Disable audio in marker generation
3 participants
@kermieisinthehouse @bnkai @WithoutPants