Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrubber sprite creation for short video files #2167

Merged
merged 6 commits into from
Jan 4, 2022

Conversation

bnkai
Copy link
Collaborator

@bnkai bnkai commented Dec 26, 2021

As it is now stash skips creation of the scrabber sprites for very short video files (< 3s)
This PR enables generation of sprites for files with low duration/frame count

For files that are < 5s or the frame count is smaller than the chunkcount (9x9) it uses a slower method to generate them
For every thumbnail extraction we use the select ffmpeg filter to extract a single frame (slow and should only be used for small files) from the video
If the number of frames are smaller than needed then duplicate frames are added to compensate

@kermieisinthehouse kermieisinthehouse added the bug Something isn't working label Dec 26, 2021
@kermieisinthehouse kermieisinthehouse added this to the Version 0.13.0 milestone Dec 26, 2021
@WithoutPants WithoutPants merged commit 849c590 into stashapp:develop Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants