Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stash-box credentials validation #2173

Merged
merged 4 commits into from
Jan 4, 2022
Merged

Add stash-box credentials validation #2173

merged 4 commits into from
Jan 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2021

image

@kermieisinthehouse kermieisinthehouse added feature Pull requests that add a new feature ui Issues related to UI labels Dec 28, 2021
@kermieisinthehouse kermieisinthehouse added this to the Version 0.13.0 milestone Dec 28, 2021
@kermieisinthehouse
Copy link
Collaborator

Tested working

@bnkai
Copy link
Collaborator

bnkai commented Dec 30, 2021

Looks and works ok.

Minor issue.
The test button can be clicked even if either of the endpoint/api key input is left blank resulting in the following errors

No response from server/Unknown error: response error: Not authorized

@WithoutPants WithoutPants merged commit 34aea87 into stashapp:develop Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature Pull requests that add a new feature ui Issues related to UI
Projects
None yet
Milestone
Version 0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kermieisinthehouse @bnkai @WithoutPants