Add Gender Icons to Performers #2179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kermieisinthehouse
added
improvement
|
The gender icon should not be shown if gender is not set. |
|
StashDB shows the the same thing if it's unset, although I can blank it out with no issue |
I can't comment on the stash-box decision, but at least for personal use, I don't think the icon gives more or better information when gender is unset that wouldn't be conveyed by just omitting the icon, and in my opinion is cleaner. |
|
Also, please add a classname to the gender icon control so that it can be manipulated via css. |
|
Fixed both :) |
…h into gender-on-performers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #434
This adds gender icons to the performer grid and detail pages. Gender types are i18n'd now, the code is adapted from stash-box.
Performer grid:
Performer detail:
