Add support for the Handy APIv2

[chetbrinko]

Docs: https://staging.handyfeeling.com/api/handy/v2/docs/
Ref: https://github.com/defucilis/thehandy

Update axios to 0.24.0 due to a security update

Progress on #1376

I've updated https://github.com/defucilis/thehandy with the change defucilis/thehandy#2 because the class HandyUtils wasn't exported, which is why this is a Draft PR. In order to test/verify the change you will need to use my branch until it is merged upstream

Also I added support for the following funscript features:

• inverted flag
• range argument

[chetbrinko]

@UnluckyChemical765 btw thank you for your earlier work on which this is based

[inventiv3919]

Do you have a docker container of this by any chance?

[chetbrinko]

@inventiv3919 https://hub.docker.com/r/chetbrinko/stash_handyv2

[kermieisinthehouse]

Testing is welcome, as none of the devs have the hardware. We can only review the code, not the functionality

[inventiv3919]

Trying to launch the docker container gives error: standard_init_linux.go:230: exec user process caused: exec format

[chetbrinko]

@inventiv3919 sorry, the docker image was built for arm - i forced it to amd64 for you so if you repull it should work - i can't verify easily as i'm on arm

[chetbrinko]

@kermieisinthehouse understood - all I can say is "works on my machine/hardware" from since I opened the PR - hopefully @inventiv3919 can provide external validation.

[inventiv3919]

@chetbrinko thanks :) I'll try test it out later today

[inventiv3919]

Just fired it up and watched a few videos, seems to work perfectly so far. I was able to change my funscript offset from -655 down to -50, definitely a big improvement

Edit: been using it for a few days now and it's still working great, sync is better and I haven't noticed any bugs.

[inventiv3919]

@chetbrinko @kermieisinthehouse I've been using it all week with no issues :)

[kermieisinthehouse]

Given how simple the bindings are, we could probably host the repo under the stashapp org.

[chetbrinko]

@kermieisinthehouse feel free to fork my fork into the org, if you please. Happy to be added as a contributor to maintain it.

Once that's done I'll mark the PR as non-draft and we can continue with getting it merged~

[inventiv3919]

@kermieisinthehouse any chance you could fork this pr now? So many new features have been added to stash and I can't update to use any of them until this is added to the main stash branch

[WithoutPants]

Is there any reason we can't use the fork as-is until it is patched upstream?

[inventiv3919]

@WithoutPants I've been using @chetbrinko 's docker container since January and haven't noticed any bugs/glitches. I'm just a bit impatient and would like to use some of the other new features I see have been added since then

[WithoutPants]

I have update to sync with the develop branch. I've changed it to use thehandy 1.0.3 package and re-implemented uploadCsv so that HandyUtils does not need to be exported for this. Once the pending PR is merged upstream, we can change the code to reference that instead.

This will need a retest from @chetbrinko, @inventiv3919 or someone else with the necessary hardware. Be aware that the shift to videojs may have introduced issues with interactive functionality, so if bugs do occur it may be worth comparing it with the current development build.

[inventiv3919]

I'll try it out once @chetbrinko updates the docker container

[WithoutPants]

@inventiv3919 I made a docker image for you to test with: withoutpants/stash:handyv2
(repo here: https://hub.docker.com/repository/docker/withoutpants/stash)

[inventiv3919]

Thanks for making the docker image @WithoutPants

The shift to videojs has indeed introduced an issue: the handy connects and syncs fine and responds accordingly when the stash player is paused/resumed however seeking ahead/back does not update the handy and there doesn't appear to be a way to resync it without reloading the page and not skipping through at all.

@chetbrinko may need to update the PR so that videojs exposes the current timepoint to the handyapi

[WithoutPants]

Thanks for making the docker image @WithoutPants

The shift to videojs has indeed introduced an issue: the handy connects and syncs fine and responds accordingly when the stash player is paused/resumed however seeking ahead/back does not update the handy and there doesn't appear to be a way to resync it without reloading the page and not skipping through at all.

@chetbrinko may need to update the PR so that videojs exposes the current timepoint to the handyapi

Pausing the video and then playing again does not sync it again?

[inventiv3919]

It does not. It pauses it but when I click play again the handy continues without resyncing

[WithoutPants]

Are you able to test while looking at the browser development console?

Under the network tab, there should be requests for hssp/play and hssp/stop. When the video starts or seeks, I expect a call to hssp/play with estimatedServerTime and startTime filled in.

Can you verify what requests are sent when starting, pausing, seeking and pausing after seeking?

[inventiv3919]

Ok I think it's a problem with Samsung internet when I used chrome on my laptop everything except the quick skip buttons worked (and then it resynced by pausing then resuming). Seems to also be working on chrome for Android so I'll switch to that browser. Sorry for wasting your time

(Oh and I checked the network tab and yes it's sending the requests with estimatedservertime & starttime filled in)

[WithoutPants]

So this PR is good to go? Not sure why the skip buttons aren't working correctly.

[inventiv3919]

I'd say so yeah, the skip buttons aren't a big deal