Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete funscripts while deleting scene #2265

Merged
merged 4 commits into from
Feb 3, 2022

Conversation

kermieisinthehouse
Copy link
Collaborator

(Reported in Discord)

Deleting a scene file would not delete the associated funscript. This changes that behavior.

@kermieisinthehouse kermieisinthehouse added this to the Version 0.13.0 milestone Jan 26, 2022
@kermieisinthehouse kermieisinthehouse added the bug Something isn't working label Jan 26, 2022
@bnkai
Copy link
Collaborator

bnkai commented Jan 27, 2022

Should the UI dialog be updated also so that the user is informed before deleting?

Delete file
Delete generated supporting files

I dont think we need to add an extra check option , just update the Delete file to include the Funscript file (if available)?

@kermieisinthehouse
Copy link
Collaborator Author

I agree we should change the copy, but any ideas to what? I don't want to make "delete file" too long, maybe "Delete File (+ funscript)"

@WithoutPants WithoutPants merged commit 10bb9a6 into stashapp:develop Feb 3, 2022
@kermieisinthehouse kermieisinthehouse deleted the delete-funscripts branch February 3, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants