Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title, rating, o-counter to image lightbox #2274

Merged
merged 6 commits into from
Mar 3, 2022

Conversation

WithoutPants
Copy link
Collaborator

See screenshots. Allows setting rating and o-counter. The title is clickable to navigate to the image page.

image
image

@WithoutPants WithoutPants added feature Pull requests that add a new feature ui Issues related to UI labels Jan 31, 2022
@WithoutPants
Copy link
Collaborator Author

Per Discord feedback, rearranged the controls so that the o-counter is on top. I also made the height of the bottom bar a little bigger to make it a little less condensed.

image

@bnkai
Copy link
Collaborator

bnkai commented Feb 3, 2022

I get a very weird error when cycling back from the first image of a gallery collection/ images page to the last

  • Go to the images page in WALL mode (1st page)
  • Click any of the images
  • Try to navigate back
  • When you get past the first image(so to the last image of your images) you get this error
Something went wrong.
TypeError: Ae is undefined
Pb@http://localhost:9998/assets/index.7c179a30.js:1773:106951 Xb@http://localhost:9998/assets/index.7c179a30.js:1773:116721 Jd@http://localhost:9998/assets/index.7c179a30.js:1:2481 Sb@http://localhost:9998/assets/index.7c179a30.js:1773:77281 t@http://localhost:9998/assets/vendor.9722a44c.js:149:3839 h9@http://localhost:9998/assets/index.7c179a30.js:1785:52414 q4@http://localhost:9998/assets/index.7c179a30.js:1802:44487 DYe@http://localhost:9998/assets/vendor.9722a44c.js:85:2523 t@http://localhost:9998/assets/vendor.9722a44c.js:114:3696 t@http://localhost:9998/assets/vendor.9722a44c.js:114:10004

@WithoutPants
Copy link
Collaborator Author

I get a very weird error when cycling back from the first image of a gallery collection/ images page to the last

  • Go to the images page in WALL mode (1st page)
  • Click any of the images
  • Try to navigate back
  • When you get past the first image(so to the last image of your images) you get this error

I'm not able to reproduce this with Chrome or Firefox.

@bnkai
Copy link
Collaborator

bnkai commented Feb 4, 2022

Update

@kermieisinthehouse
Copy link
Collaborator

On firefox, webkit, and chrome, updates to the o-counter are delayed until some other events are processed (like zooming the image, clicking other buttons, etc.) There's an event loop issue somewhere

@WithoutPants
Copy link
Collaborator Author

On firefox, webkit, and chrome, updates to the o-counter are delayed until some other events are processed (like zooming the image, clicking other buttons, etc.) There's an event loop issue somewhere

I'm not able to reproduce this on Firefox or Chrome on Windows or Linux.

@WithoutPants WithoutPants added this to the Version 0.13.0 milestone Mar 1, 2022
@WithoutPants WithoutPants merged commit 0737ca9 into stashapp:develop Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature ui Issues related to UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants