Make changes to fix special characters in Criterion labels (#1819) #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reverse the '&' and '+' replacement done on StringCriterion Decodes special characters in IHierarchicalLabeledIdCriterion
kermieisinthehouse
approved these changes
Feb 9, 2022
kermieisinthehouse
approved these changes
Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse the '&' and '+' replacement done on StringCriterion
Decodes special characters in IHierarchicalLabeledIdCriterion
Issue #1819
209-212 just undo what was done during encodeValue(). The downside is that if somebody has %2B in their string it will decode that to a '+' instead of showing '%2B' if that was desired. Likewise if they have an encoded '&' that they purposefully want. But that seems rare. This only affects the display of this data.
I also noticed that a more widespread issue was happening with the IHierarchicalLabeledIdCriterion where it was URI encoded in the database but not decoded for display. So you would see strings like "Bob%20Ross" doing similar steps but with something like filtering by studio. This fixes that as well. Again it only alters the display value, nothing in the URL or data passed around for the application.