Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the preview generation task on some files (very small percentage) the process seemed to take too much time to complete.
Upon investigation it seems that the trimmed files to be concatenated had weird durations / timings and so the resulting mp4 file generated had also weird fps (0.001) making the generate task stuck to a single scene for hours.
Simply changing the order of the ffmpeg
-t
parameter after the input-i
fixes all weird occurences and goes past the problematic files as it should.I couldn't find anything in common for the files affected (original,reencodes,mp4,webm ) , i could only verify through discord that the specific change is indeed generating correct previews with the problematic media files.