Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make scene metadata from file metadata optional #259

Merged
merged 1 commit into from
Dec 13, 2019

Conversation

WithoutPants
Copy link
Collaborator

This change extends #136 to make all of the file-based metadata extraction optional, since it is frequently incorrect. It makes all of the behaviour introduced in #103 optional, with the exception of the title defaulting to the filename. The checkbox in the settings for this has been renamed to "Set name, date, details from metadata (if present)" and is now unchecked by default.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Dec 12, 2019
@bnkai
Copy link
Collaborator

bnkai commented Dec 12, 2019

Works ok for me.
I think if we exclude a few people that tag their media files the majority of files have comments and titles that are either irrelevant or not well defined anyway.

@Leopere Leopere merged commit c05496a into stashapp:develop Dec 13, 2019
@WithoutPants WithoutPants mentioned this pull request Feb 4, 2020
10 tasks
@WithoutPants WithoutPants deleted the optional_file_metadata branch May 15, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants