Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow uploading of custom scene covers #262

Merged
merged 4 commits into from
Dec 13, 2019

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Dec 13, 2019

Adds a "Cover Image" section to the Edit Scene page. This is an expandable section that is collapsed by default, as follows:

image

Expanding this shows the current cover image, with a file selector to select a new cover image:

image

Like the other image selection pages, Ctrl-V with an image in the clipboard will paste the image directly.

Note that saving the scene after updating the cover image does not update the cover image in the video player until the page is reloaded.

Should address #35

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Dec 13, 2019
@bnkai
Copy link
Collaborator

bnkai commented Dec 13, 2019

Looks ok.
Tested the addition through file browse, paste.
Works ok in the scenes grid,list and the player.
It replaces the original screenshot, thumbnail so no problem with the clean task also.

@Leopere Leopere merged commit da3e911 into stashapp:develop Dec 13, 2019
@WithoutPants WithoutPants mentioned this pull request Feb 4, 2020
10 tasks
@WithoutPants WithoutPants deleted the scene_cover branch May 15, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants