jwplayer transcode seek support. Remove video.js #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fine for me. |
Leopere
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change means that all video files are shown only in jwplayer, instead of showing video.js for non-streamable files. This change includes a local change to the jwplayer code, which is maintained in the
hooksbranch of my personal fork of the jwplayer project, available here: https://github.com/WithoutPants/jwplayer/tree/hooksThis version of jwplayer allows hooking into the
getDuration,seekandgetPositionmethods to override them. The stash code was changed to make use of these hooks in the same way that it hooked into the same methods in video.js.Since video.js is no longer used or required, it was removed.