-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scenes tab to performer page #280
Conversation
Everything seems to function ok. |
Marked as WIP while I do another iteration on this to make it more like the mock ups in #124 |
Changed the layout. Favourite button added to heading, along with the URL link as an icon. Instagram and Twitter not added in as blueprint doesn't have the icons for these. Age and aliases now shown in the header. Tabs moved below the image. Image can be clicked to show a full-screen view. URL and social links now displayed as actual links: Edit screen has normal name and alias fields now, and favourite has been removed in favour of the button at the top: I'm still not super-sold on all the empty space to the right of the image, but we could probably fill it with other details, like number of scenes, performer tags (if/when implemented). The new performer page still looks like the old version. |
It looks ok to me the only thing if possible is what i mentioned in discord |
Looks brilliant! Thank you Please can you confirm that if you select a field, tab out, tab back in, does it lose focus or keep it? :) |
b567304
to
76cb714
Compare
Confirmed that tabbing out and back does not lose focus on fields. Blueprint implements tab contents within the tabs object. In order to have the tab headers next to the performer image, the tabs would need to be in a different element than the tab contents. I could probably hack a way around it, but I don't think it's worth it right now. We can re-evaluate with the UI refresh. |
thanks for confirming mate :) |
* Make performer page tabbed * Add performer scenes tab * Make performer scenes criteria smarter * Adjust performer page layout. Add URL links * Add lightbox for performer image * Alias editing
This change adds a set of tabs to the performer page: Details, Edit, Scenes and Operations.
Details and Edit tabs should look like the old page, with the fields only editable in the Edit tab. The Delete and Scrape buttons have been moved into this tab.
The Scenes tab shows a scenes list filtered on the performer.
The Auto Tag button has been moved to Operations.
The only thing I'm really unhappy with for this change is that when the right panel scrolls, then the image scrolls up with it and there is a bunch of empty space on the left. I wanted to make the right panel independently scrollable, but I haven't been able to get the CSS to work correctly for it. It would also have to be compatible with smaller screens as well. To my mind, the