Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scenes tab to performer page #280

Merged
merged 7 commits into from
Jan 5, 2020

Conversation

WithoutPants
Copy link
Collaborator

This change adds a set of tabs to the performer page: Details, Edit, Scenes and Operations.

Details and Edit tabs should look like the old page, with the fields only editable in the Edit tab. The Delete and Scrape buttons have been moved into this tab.

image

image

The Scenes tab shows a scenes list filtered on the performer.

image

The Auto Tag button has been moved to Operations.

image

The only thing I'm really unhappy with for this change is that when the right panel scrolls, then the image scrolls up with it and there is a bunch of empty space on the left. I wanted to make the right panel independently scrollable, but I haven't been able to get the CSS to work correctly for it. It would also have to be compatible with smaller screens as well. To my mind, the

@WithoutPants
Copy link
Collaborator Author

Related to #124 and #108

@bnkai
Copy link
Collaborator

bnkai commented Dec 20, 2019

Everything seems to function ok.
A cosmetic suggestion , when you switch to the Scenes or Operations tabs it seems a little weird with the performer name missing. Maybe add the performer name there also or keep the performer name above the tabs element?
For the scrolling i get what you mean , i played a little with fixed positioning but it has its problems also...

@bnkai bnkai added the improvement Something needed tweaking. label Dec 20, 2019
@WithoutPants WithoutPants changed the title Add scenes tab to performer page [WIP] Add scenes tab to performer page Dec 20, 2019
@WithoutPants
Copy link
Collaborator Author

Marked as WIP while I do another iteration on this to make it more like the mock ups in #124

@WithoutPants
Copy link
Collaborator Author

Changed the layout. Favourite button added to heading, along with the URL link as an icon. Instagram and Twitter not added in as blueprint doesn't have the icons for these. Age and aliases now shown in the header. Tabs moved below the image. Image can be clicked to show a full-screen view.

image

URL and social links now displayed as actual links:

image

Edit screen has normal name and alias fields now, and favourite has been removed in favour of the button at the top:

image

I'm still not super-sold on all the empty space to the right of the image, but we could probably fill it with other details, like number of scenes, performer tags (if/when implemented).

The new performer page still looks like the old version.

@WithoutPants WithoutPants changed the title [WIP] Add scenes tab to performer page Add scenes tab to performer page Jan 4, 2020
@bnkai
Copy link
Collaborator

bnkai commented Jan 4, 2020

It looks ok to me the only thing if possible is what i mentioned in discord is there a way to split the Tabs so that the the titles go to the right of the performer image while the panel contents go underneath? . Otherwise works/tests ok for me.

@VonTittyslappen
Copy link

Looks brilliant! Thank you

Please can you confirm that if you select a field, tab out, tab back in, does it lose focus or keep it?

:)

@WithoutPants
Copy link
Collaborator Author

Confirmed that tabbing out and back does not lose focus on fields.

Blueprint implements tab contents within the tabs object. In order to have the tab headers next to the performer image, the tabs would need to be in a different element than the tab contents. I could probably hack a way around it, but I don't think it's worth it right now. We can re-evaluate with the UI refresh.

@VonTittyslappen
Copy link

thanks for confirming mate :)

@Leopere Leopere merged commit bab7c8f into stashapp:develop Jan 5, 2020
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Jan 23, 2020
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Feb 2, 2020
@WithoutPants WithoutPants mentioned this pull request Feb 4, 2020
10 tasks
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Feb 8, 2020
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Mar 1, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Make performer page tabbed

* Add performer scenes tab

* Make performer scenes criteria smarter

* Adjust performer page layout. Add URL links

* Add lightbox for performer image

* Alias editing
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@WithoutPants WithoutPants deleted the performer_ui branch February 4, 2021 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants