Change thumbnail default size and resize algorithm #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnkai
added
feature
ghost
changed the title
bnkai
reviewed
Jan 29, 2020
bnkai
reviewed
Jan 29, 2020
|
Tests ok, two possible cosmetic typos. |
Leopere
approved these changes
Jan 31, 2020
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Change thumbnail resize algorithm and add size parameter * Height -> Width * Change default size from 100px to 200px * Height -> width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change thumbnail generation algorithm to 'Box' rather than NearestNeighbor, and change the default size from 100px to 200px.
Also added a size parameter to url query to allow for variable quality in galleries.
Box is about 25% slower than Nearest Neighbor by my measurements, but the quality is well worth it. A future enhancement might be to make the generation algo a user setting, since some users might prefer Lanczos or similar that offers sharper results.
Also, please excuse the format diff noise.