Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.1.0 release #345

Merged
merged 7 commits into from
Feb 6, 2020

Conversation

WithoutPants
Copy link
Collaborator

Version is now generated in the Makefile and cross-compile.sh script, and uses git describe --tags --exclude latest_develop to generate a version string. From the git describe help page:

If the tag points to the commit, then only the tag is shown. Otherwise, it suffixes the tag name with the number of additional commits on top of the tagged object and the abbreviated object name of the most recent commit.

The latest develop release is now tagged with latest_develop. It will be named for the version string generated above.

Builds on the master branch will now only be released if the commit is tagged with a tag that is not latest_develop. Builds on this branch will be done as a draft allowing maintainers to confirm the release before making it publicly available. It also allows changelogs to be filled in as needed.

Changed the check version code so that it determines whether it is a development build by checking the version string. If the version string contains the generated suffixes, then it must be a development build. For development builds, it now calls the github API /repos/stashapp/stash/releases/tags/latest_develop endpoint, which returns the release for the latest_develop tag. For release builds, it now calls the github API /repos/stashapp/stash/releases/latest endpoint, which returns the most recent full release.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Feb 4, 2020
@WithoutPants WithoutPants added this to the Version 0.1.0 milestone Feb 4, 2020
@WithoutPants
Copy link
Collaborator Author

Related to #339

@WithoutPants
Copy link
Collaborator Author

I've also added a two minute limit to the transfer.sh upload call so that slow upload speeds don't kill the build.

@bnkai
Copy link
Collaborator

bnkai commented Feb 5, 2020

Most changes here depend on Travis and the new tag you created.
From what i checked they look ok but we can't really test unless travis provides a binary and the new tag gets created...

@WithoutPants WithoutPants merged commit 3c1eeb3 into stashapp:develop Feb 6, 2020
@WithoutPants WithoutPants deleted the release_versions branch May 15, 2020 07:13
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Tag develop builds as latest. Version in makefile
* Rename latest to latest_develop
* Update GetLatestVersion
* Separate master and develop releases
* Add release date back into development version
* Remove unused code
* Two minute limit per file to upload to transfer.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants