-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate cover image #376
Generate cover image #376
Conversation
Is this WIP? First by changing the operations to mutation i get this Also you are using ( in generateImageAt) the generator from the previews task that was supposed to generate the previews and the webp for the wall view not the screenshots. This leads to this error when trying to "create a thumbnail" which is because you are using image generate options (-f image2) that are not compatible with webp (g.ImageFilename). The screenshots code should work like task_scan.go->makeScreenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The screenshot / thumbnails generation seems to work fine.
A point to consider though. If the user wants to have a custom screenshot shouldn't this screenshot also update the cover in the DB ? Otherwise it will not be exportable. This also affects the consinstency of the cover image function.
If you make a new screenshot while there is a cover in the DB then the screenshot gets generated fine and all the images you see in the UI including the cover one are from that screenshot. The cover image is still in the DB but nowhere to be seen.
IMHO when the screenshot changes then the cover ( if it exists in the DB ) should be in sync with it.
Yeah, you're right. The earlier version did that, but forgot to port that in during the rework. |
48e77a2
to
b5543c2
Compare
Added setting image in the database and ported to 2.5 UI. Ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests ok for me (default,custom,thumbnails,db) , both v2 and v2.5
* Make mutating metadata ops mutation * Implement scene generate screenshot * Remove fetch policy on metadata mutations * Port UI changes to v2.5 * Set generated image in database
Resolves #9
Note: this change also moves the scan/generate/import/export operations from
query
tomutation
, since these are mutating operations. This will impact external scripts using these operations.Adds a new tab to the scene page - Operations. Within this tab, there are two buttons. One generates the cover image for the scene based on the current position of the scene player, the other generates the cover image using the default settings.
Note that a page refresh may be required to see the updated images after generation, due to caching.