Make displayed resolution information coherent for 2:1/VR files #3798
Conversation
Displayed resolutions in Stash were confusing as hell when it came to VR files - which are typically 2:1. Now I understand why, it's assuming 16:9 files/looking at height only.
5120x2560 was common as well actually
ui/v2.5/src/utils/text.ts
Outdated
There was a problem hiding this comment.
I think the width should be used to approximate anything that has a K label.
That should work for both regular 2D and VR files better than this solution.
There was a problem hiding this comment.
Wouldn't that introduce issues for portrait content? I was trying to stay within the constraints of how it was already set up.
Plus I think that would introduce issues because the lower ones are all ###p
I can try and re-write it to only look at width in general
|
There's also plenty of 7K (7168 x 3584) scenes out there and at least one 12K (12288 x 6144) |
@Emilo2 Added a 7K and a HUGE display for both. IMO to be "just right" it'd need to handle 1:1 / But I'm not sure how to do that without mucking things up. |
DogmaDragon
added
improvement
|
If it helps that's a distinct list of VR resolutions from my library:
|
|
Thank you @Kruk2
I have some of those too, but 1440p ain't so bad as a display in Stash. At least it's accurate.
Genuinely wasn't expecting those two. I am worried that trying to stick within the constraints of how it currently works might be too cumbersome. |
6K = 6000x3000
6000x3000 = 6K
|
Yeah, I think there would have to be some kind of flexible rules so we can assign 8K to a range of heights? 6000x3000 |
|
I changed the criteria for 6K so now it starts at 3000 height. 8000x4000 was already covered by the 8K rule. |
|
Update to reflect the current state of the changes the commit makes.
If Height > Width (portrait video) then it already looks at the larger of the two by default, ie. a 2160x3840 video will also say "4K". If there's some bizarre portrait aspect smartphone camera resolution I've borked with this, please let me know. This (now gracefully, thank you @WithoutPants ) deprecates the old "VR_HD" label. It also doesn't do anything to fix how it handles older 1:1 / TB VR videos, since the way Stash (already) handles resolution relies on "looking at the larger of height/width" and making its decision from there. e.g. 2160x2160 VR already erroneously displays "4K" - since it's just looking at "2160". 16:9 3840 x 2160 is 4K, it's not wrong. It does unfortunately do away with e.g. 2144x2144 correctly triggering Vr_Hd internally even though it still showed "1920p" in the UI for those; those become "4K" now too. Someone smarter than me might want to try and implement handling for 1:1 video, but they're far and few from the dark ages of VR, at least in my Stash. |
Update to reflect the current state of the changes the commit makes.
>=DimensionHUGE"Wait and see" what the "next label" after 8K will be.
If Height > Width (portrait video) then it already looks at the larger of the two by default, ie. a 2160x3840 video will also say "4K". If there's some bizarre portrait aspect smartphone camera resolution I've borked with this, please let me know.
This deprecates the old "VR_HD" label. It also doesn't do anything to fix how it handles older 1:1 / TB VR videos, since the way Stash (already) handles resolution relies on "looking at the larger of height/width" and making its decision from there. e.g. 2160x2160 VR already erroneously displays "4K" - since it's just looking at "2160". 16:9 3840 x 2160 is 4K, it's not wrong. It does unfortunately do away with e.g. 2144x2144 correctly triggering Vr_Hd internally even though it still showed "1920p" in the UI for those; those become "4K" too.
Someone smarter than me might want to try and implement handling for 1:1 video.
Original comment below.
Displayed resolutions in Stash were confusing as hell when it came to VR files - which are typically 2:1. Now I understand why, it's assuming 16:9 files/looking at height only.
These changes will make it display
If that doesn't work, it should be modified to look at width.