-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagger config option to mark scene as organized #4031
Tagger config option to mark scene as organized #4031
Conversation
Thank you for this PR! My skills only allow me to comment on the wording. I think there's a editing mistake on the feature description: "[...] when the click the Save button is clicked". While we're at it, my suggestions: LabelFor conciseness, since there will be a description below:
DescriptionI could think of two options:
|
@grabolento Thanks for the feedback - I've updated the wording 👍 |
This option currently overrides the current value of "Organized" and in its default state it will unmark any currently "Organized" scene. I think we would want to make this where it does nothing unless selected in which case it sets the value |
Fixed by #4213 |
This pull request is a first attempt at adding a config option to the Scene Tagger view to immediately mark a scene or scenes as Organized on save, as described in issue #3731.
I've added this as an additional option in the Configuration pane, like so:
This currently defaults to current behaviour, i.e. a scene will not be set to Organized on save - the new behaviour is opt-in.
Also, please let me know if the wording of the label and description of the new config option is acceptable - this can be changed if needed.
Resolves #3731