Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagger config option to mark scene as organized #4031

Merged
merged 5 commits into from
Aug 24, 2023

Conversation

plato178
Copy link
Contributor

@plato178 plato178 commented Aug 14, 2023

This pull request is a first attempt at adding a config option to the Scene Tagger view to immediately mark a scene or scenes as Organized on save, as described in issue #3731.

I've added this as an additional option in the Configuration pane, like so:

Screenshot 2023-08-14 at 21 52 10

This currently defaults to current behaviour, i.e. a scene will not be set to Organized on save - the new behaviour is opt-in.

Also, please let me know if the wording of the label and description of the new config option is acceptable - this can be changed if needed.

Resolves #3731

@grabolento
Copy link

Thank you for this PR!

My skills only allow me to comment on the wording. I think there's a editing mistake on the feature description: "[...] when the click the Save button is clicked".

While we're at it, my suggestions:

Label

For conciseness, since there will be a description below:

Mark as Organized on save

Description

I could think of two options:

Immediately mark the scene as Organized after clicking the Save button.
Immediately mark the scene as Organized after the Save button is clicked.

@plato178
Copy link
Contributor Author

@grabolento Thanks for the feedback - I've updated the wording 👍

@plato178 plato178 changed the title Tagger mark organized Tagging config option to mark scene as organized Aug 22, 2023
@plato178 plato178 changed the title Tagging config option to mark scene as organized Tagger config option to mark scene as organized Aug 22, 2023
@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Aug 24, 2023
@WithoutPants WithoutPants added this to the Version 0.23.0 milestone Aug 24, 2023
@WithoutPants WithoutPants merged commit 3323477 into stashapp:develop Aug 24, 2023
2 checks passed
@plato178 plato178 deleted the tagger-mark-organized branch August 24, 2023 13:08
@stg-annon
Copy link
Collaborator

This option currently overrides the current value of "Organized" and in its default state it will unmark any currently "Organized" scene.

I think we would want to make this where it does nothing unless selected in which case it sets the value

@DogmaDragon
Copy link
Collaborator

Fixed by #4213

halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add option to mark scene as organized when identifying through Tagger view
5 participants