Details pages start with populated content tab #4032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WithoutPants
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has bothered me for a while, and I think there was also a ticket once, but not by me and I was not able to find it.
This Commit simply makes it that if you open the details page of a tag, a studio or a performer, instead of always showing the scenes of this organization unit, it will check whether it even has a scene to begin with. If there isn't one, it will show the first thing it has, going through the available media types from left to right (so for example performer will default to scene->gallery->image->movie). If there is simply no media associated with this organization unit, it defaults to scene again to minimize impact in general.
The only exceptional thing here would be the studio details page, which has the childrens as a tab. These are handled as if they were a media type, and will become the default tab if no other media is associated with the studio.
I think this is a pretty uncontroversial commit, but if there are questions don't hesitate to ask.
It will (hopefully) make life easier for people managing more diverse kinds of media types with stash.