Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sub navbar render extra optional buttons for ui & interface config settings. #4245

Closed
wants to merge 2 commits into from

Conversation

elkorol
Copy link
Contributor

@elkorol elkorol commented Oct 26, 2023

In this pr, allows a settings configurable option to render the following settings as subnav bar button elements

  • soundOnPreview: for scene & marker wall to toggle off playing of audio while hovering over card.
  • showChildStudioContent: while in a studio view toggle showing of sub studio items as well as main studio items
  • showChildTagContent: while in a tag view toggle showing of sub tag items as well as main tag items
  • showTagCardOnHover: ability to toggle on and off that card HoverPopover.

Notes

Some pages such as Scene, Image, Marker, Studios & the Tags page, do not render even if the setting is true, any additional sub navbar elements. As these pages don't actually display such things associated with any of the settings. The icons of the buttons have different tooltips when enabled or disabled. And when enabled the FontAwesome Icon rendered Lime Green - Green I thought was too dull. I thought as these are view control elements and the fact that they render the Icons on enable green seemed suitable. But if isn't liked, I can easily remove it. . The soundOnPreview setting uses the FontAwesome icon: faVolumeXmark while disabled and faVolumeHigh while enabled. I thought about making others have dual icons. But couldn't seem to find suitable icons other than the ones for the audio setting.

Interface Setting Panel

1

Scenes page

2a 2b 2c 2d

Images page

3-images

Markers page

4-markers

Galleries page

5-galleries

Gallery page

6-gallery

Performers page

7-Performers

Performer page

8-performer

Studio page

9-studio-a 9-studio-b

Tag page

10-tag-a 10-tag-b

@scruffynerf
Copy link

I'd rather see each new button with a toggle.

@WithoutPants
Copy link
Collaborator

I think the underlying requirement here would be better served with a plugin to add these buttons. I'm not aware of any particular demand for being able to toggle these options within the list views, and this adds more buttons to an already crowded toolbar, and a rather vague UI setting.

As part of #4453, we should endeavour to make it easy for plugin developers to add new buttons to the toolbar, and then this can be implemented as a plugin instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants