Fix performer validation #4248
Merged
Fix performer validation #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added case-insensitive duplicate alias validation. Fixes #4250 |
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
* Fix performer validation * Add tests * Rename QueryCount argument * Minor refactoring * Add duplicate alias validation * Make UI alias validation also case-insensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves/fixes the validation on performer create/update, and packages everything into convenient
ValidateCreateandValidateUpdatefunctions that are then used in the resolvers.The main issue fixed is that performers were able to conflict with themselves when updating, causing the issue in #4229.
I've then also added a check to error on an empty name, which is enforced in the UI but not in the backend.
Similar changes to the validation for the other object types (studios, tags, etc) will come in the future.
Fixes #4229
Fixes #4250