Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added various missing filters to performer page #438

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

Anon247
Copy link
Contributor

@Anon247 Anon247 commented Apr 2, 2020

Filters have been added to the performer page. I think that the 'Is Missing' criterion will need to be cleaned up and abstracted soon if we're going to be adding the 'Is Missing' criterion to other pages; I wasn't sure what would be the best way of doing it so I just duplicated it for now. Also, only applied changes to V2.5 UI as the switchover is soon.

Supported missing parameters:

  • url
  • twitter
  • instagram
  • ethnicity
  • country
  • eye_color
  • height
  • measurements
  • fake_tits
  • career_length
  • tattoos
  • piercings
  • aliases
  • gender
  • scenes

@bnkai
Copy link
Collaborator

bnkai commented Apr 2, 2020

closes #436

@bnkai bnkai linked an issue Apr 2, 2020 that may be closed by this pull request
Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things.

pkg/models/querybuilder_performer.go Outdated Show resolved Hide resolved
pkg/models/querybuilder_performer.go Show resolved Hide resolved
@Anon247
Copy link
Contributor Author

Anon247 commented Apr 3, 2020

@WithoutPants any thoughts on duplicating the IsMissingCriterion?

@Anon247 Anon247 force-pushed the IsMissingPerformerFilter branch 2 times, most recently from b22761d to e20fa76 Compare April 3, 2020 10:13
@bnkai
Copy link
Collaborator

bnkai commented Apr 3, 2020

They seem to work ok.

@VonTittyslappen
Copy link

Thanks guys, whilst this is being added, would functionality to bulk remove performers (ie. ones that have 0 scenes) be possible? Do you want me to raise that as a feature "issue" instead?

@Anon247
Copy link
Contributor Author

Anon247 commented Apr 5, 2020

Yes, this would be a separate PR so raise another issue for it 👍

@WithoutPants WithoutPants merged commit dc37a30 into stashapp:develop Apr 8, 2020
@VonTittyslappen
Copy link

VonTittyslappen commented Apr 8, 2020

Unfortunately something has broken, if I remove a date of birth and save, the DOB disappears, but when I refresh the screen, the DOB comes back, this used to work without issue, I think this commit has borked this somehow

@Anon247 Anon247 deleted the IsMissingPerformerFilter branch April 8, 2020 13:22
@WithoutPants
Copy link
Collaborator

Unfortunately something has broken, if I remove a date of birth and save, the DOB disappears, but when I refresh the screen, the DOB comes back, this used to work without issue, I think this commit has borked this somehow

Tested on the version prior to this one and also got the same result, so this PR is not the cause. Please raise a bug for this. Not sure which commit may have caused this regression.

Anon247 added a commit to Anon247/stash that referenced this pull request Apr 11, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add "Missing Gender" filter to performer section
4 participants