-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added various missing filters to performer page #438
Added various missing filters to performer page #438
Conversation
closes #436 |
b9896f0
to
8057108
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things.
@WithoutPants any thoughts on duplicating the IsMissingCriterion? |
b22761d
to
e20fa76
Compare
e20fa76
to
5703a68
Compare
They seem to work ok. |
Thanks guys, whilst this is being added, would functionality to bulk remove performers (ie. ones that have 0 scenes) be possible? Do you want me to raise that as a feature "issue" instead? |
Yes, this would be a separate PR so raise another issue for it 👍 |
Unfortunately something has broken, if I remove a date of birth and save, the DOB disappears, but when I refresh the screen, the DOB comes back, this used to work without issue, I think this commit has borked this somehow |
Tested on the version prior to this one and also got the same result, so this PR is not the cause. Please raise a bug for this. Not sure which commit may have caused this regression. |
Filters have been added to the performer page. I think that the 'Is Missing' criterion will need to be cleaned up and abstracted soon if we're going to be adding the 'Is Missing' criterion to other pages; I wasn't sure what would be the best way of doing it so I just duplicated it for now. Also, only applied changes to V2.5 UI as the switchover is soon.
Supported missing parameters: