Warn if ffmpeg lacks codecs #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer ffmpeg with codec support if path not explicitly set.
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
Prefer ffmpeg with codec support if path not explicitly set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression introduced in #4688 where it was no longer possible to use an ffmpeg binary if it didn't have support for certain codecs.
New behaviour is:
$PATHand$HOME/.stash. It will use the first one it finds that has all of the codec support, falling back to the first one if none of them have support.Fixes #4814