Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags to studios #4858

Merged
merged 17 commits into from
Jun 18, 2024
Merged

Add tags to studios #4858

merged 17 commits into from
Jun 18, 2024

Conversation

bob123491234
Copy link
Contributor

Allows tags to be added to studios.

Everything functions as expected, but there are a number of errors relating to missing methods in the mock files. I don't know what I am missing in order to make it generate the methods.

Resolves #2497

@WithoutPants
Copy link
Collaborator

Run make generate-test-mocks

@WithoutPants WithoutPants added feature Pull requests that add a new feature bounty This issue has a bounty on it in the OpenCollective labels Jun 18, 2024
@WithoutPants WithoutPants marked this pull request as ready for review June 18, 2024 05:51
@WithoutPants WithoutPants added this to the Version 0.27.0 milestone Jun 18, 2024
@WithoutPants WithoutPants merged commit b3d35df into stashapp:develop Jun 18, 2024
2 checks passed
@WithoutPants
Copy link
Collaborator

Thanks for your contribution @bob123491234. I removed the studio_tags filter from the filter types since these are handled by the studios_filter field. The nested filters aren't yet integrated into the UI, so for the sake of expediency I've removed these from the UI for the time being.

You are eligible for the bounty on #2497. Please submit an expense request for $33.51 (which is the net amount after OpenCC fees), with Bounty issue #2497 ($40 minus fees) as the description. Add a comment here with the link so that I can verify the expense is yours.

Alternatively, if you prefer to reassign the bounty to another issue, let me know.

damontecres added a commit to damontecres/StashAppAndroidTV that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty This issue has a bounty on it in the OpenCollective feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Tags for studios
2 participants