Performer urls #4958
Merged
Performer urls #4958
+992
−379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The old Instagram and Twitter fields allowed for users to only enter a username, this does not account for that in the migration. |
|
Small thing: is the same styling of URL icons intentional? I noticed the Instagram icon is no longer pink but blue. |
Good catch, thanks. The migration has been updated to translate strings that don't start with
Nope. This is now addressed as well. Thanks for the heads up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
url,twitterandinstagramfields with a singleURLsfield. The old fields are deprecated - scrapers using the old field will have the values populated in the URLs field.The link button in the Performer page will now show a dropdown of all URLs. Twitter and Instragram links are still shown as separate link buttons and are not included in the URL dropdown.
Resolves #703