Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parser support for 3-letter month #500

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

WithoutPants
Copy link
Collaborator

Adds an {mmm} parser field to the scene filename parser. Matches against three letter month such as Jan (case-insensitive).

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 24, 2020
@WithoutPants WithoutPants added this to the Version 0.2.0 milestone Apr 24, 2020
@bnkai
Copy link
Collaborator

bnkai commented Apr 25, 2020

Looks ok, works ok also.
A small observation
If month is supported like this shouldn't the day also be supported in single digit?
Apr.5.2020 for example is more common in this notation than Apr.05.2020

@WithoutPants
Copy link
Collaborator Author

We currently have {d} as delimiter. This can easily be changed to another character.

We really want either {dd} to accept one or two date characters, or have the new {d} field accept one or two date characters. A single-only date field would be of pretty limited use. I am leaning towards using a new {d} single/double date field currently. That said, given that the design on this isn't straightforward, I think we can push this to a separate PR rather than creeping the scope of this one.

@WithoutPants WithoutPants merged commit 309f704 into stashapp:develop Apr 26, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
@WithoutPants WithoutPants deleted the mmm-month branch February 4, 2021 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants