Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for performer countries #508

Merged
merged 2 commits into from
May 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 29, 2020

Adds SVG flags to the performer cards and the performer page.

Uses some fuzzy matching to parse common "misspellings" like USA, United Kingdom, Russia, etc. For v0.3 I'd like to migrate the country field to a fixed ISO field so we don't need to do this kind of parsing, but I'll leave it alone for now and see how it works out.

image

image

@bnkai
Copy link
Collaborator

bnkai commented Apr 29, 2020

From a quick test it looks good.
Another entry for the fuzzy matching
Czechia : CZ , Czechia should be detected though
Also on performers were multiple countries are present ( comma or space seperated) none is displayed as a flag.

@ghost
Copy link
Author

ghost commented Apr 29, 2020

Another entry for the fuzzy matching
Czechia : CZ , Czechia should be detected though

Seems like the library is a bit out of date on that point. There's a PR to fix it but the maintainer isn't super active. Anyway, added it.

Also on performers were multiple countries are present ( comma or space seperated) none is displayed as a flag.

What would be the expected behavior? Should the first match or the last?

@WithoutPants WithoutPants added this to the Version 0.2.0 milestone Apr 29, 2020
@bnkai
Copy link
Collaborator

bnkai commented Apr 30, 2020

Ideally it should match all but since we didn't enforce a specific delimiter to split the countries eg comma either option mentioned is fine by me.

Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and tests ok. I'm happy to defer handling of multiple countries to later.

@WithoutPants WithoutPants merged commit a4edd21 into stashapp:develop May 3, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants