Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable wall preview type #510

Merged
merged 14 commits into from
May 26, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2020

Adds an option to select either video, animation or image previews for walls. Also adds a setting for preview generation preset.

I've refactored the wall components to largely only use css properties, this has the advantage of being more exact and deterministic. Also fixed a few issues like the gaps between wall items on larger screens, and the flashing when the page loads.

IMO the experience is a lot better since video playback is completely smooth, plus it saves a bunch of time and space from not having to generate webps.

@ghost ghost marked this pull request as draft April 30, 2020 07:27
@bnkai
Copy link
Collaborator

bnkai commented Apr 30, 2020

Using firefox (linux) with ryzen 5 1600 (6c/12t)
The cpu usage goes from 15% to 30% ( 20 per page) when switching from webp to mp4
When i change to 60 per page i have 43 % usage for webp and all seems ok but for mp4 firefox doesn't play correctly all the videos.
Chrome behaves ok even with 60 per page and with lower cpu usage ( 30% webp 45% mp4)

@whitty-username
Copy link

+1 on this pull request. This will make the experience so much better for Safari & iOS users like myself. The wall view was one of the few things keeping me using Firefox. Would love to see this merged.

@ghost ghost force-pushed the wall-previews branch 2 times, most recently from d7a1fe4 to daae3b4 Compare May 8, 2020 21:33
@ghost ghost marked this pull request as ready for review May 18, 2020 19:14
@WithoutPants WithoutPants added this to the Version 0.2.0 milestone May 22, 2020
@WithoutPants
Copy link
Collaborator

This is behaving a bit weird for me. Query for a single scene and you get a very small preview:

image

Layout is a bit odd in general if you don't get enough scenes to fill the horizontal space.

When If you mouse over a preview when Enable sound is checked, then the audio continues to be played after mousing away from the preview. You end up with a cacophony of sound (I tested this with family movies; testing it with porn would've been interesting).

The quality dropdown needs a label on it in the Generated Content section:

image

I realise it has a description underneath, but it's a bit jarring having the checkbox and the Slow.

@ghost
Copy link
Author

ghost commented May 22, 2020

@WithoutPants PR has been updated, although github is struggling right now and doesn't seem to have caught up. Have fixed the issue with <5 scenes, fixed sound playback, and zoom directions. Also cleared up the settings a bit.

@WithoutPants
Copy link
Collaborator

There's a regression in the display of portrait previews in mobile display. The existing behaviour has a fixed height for all previews. The PR version doesn't limit the height, so portrait previews appear much larger than the other previews.

@ghost
Copy link
Author

ghost commented May 24, 2020

@WithoutPants Ah right, fixed.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label May 25, 2020
@WithoutPants
Copy link
Collaborator

One more regression: the scene titles don't show up any more, regardless of if the option is enabled.

@ghost
Copy link
Author

ghost commented May 25, 2020

@WithoutPants Oof, tried to render the function instead of calling it. Fixed.

Copy link
Collaborator

@WithoutPants WithoutPants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a regression in the wall behaviour where the 15th element (last element on the 3rd row) doesn't move to the correct position. It is getting transform-origin-bottom when I think it needs to be getting transform-origin-right.

Ungenerated marker previews are not shown in video and static image modes.

ui/v2.5/src/components/Wall/WallPanel.tsx Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented May 26, 2020

@WithoutPants Good catch, I've fixed the bugs and added a generation message.

@WithoutPants WithoutPants merged commit 4ec6d62 into stashapp:develop May 26, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add optional image preview generation
* Add setting for video preview encoding preset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants