-
-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectable wall preview type #510
Conversation
Using firefox (linux) with ryzen 5 1600 (6c/12t) |
+1 on this pull request. This will make the experience so much better for Safari & iOS users like myself. The wall view was one of the few things keeping me using Firefox. Would love to see this merged. |
d7a1fe4
to
daae3b4
Compare
This is behaving a bit weird for me. Query for a single scene and you get a very small preview: Layout is a bit odd in general if you don't get enough scenes to fill the horizontal space. When If you mouse over a preview when The quality dropdown needs a label on it in the I realise it has a description underneath, but it's a bit jarring having the checkbox and the |
@WithoutPants PR has been updated, although github is struggling right now and doesn't seem to have caught up. Have fixed the issue with <5 scenes, fixed sound playback, and zoom directions. Also cleared up the settings a bit. |
There's a regression in the display of portrait previews in mobile display. The existing behaviour has a fixed height for all previews. The PR version doesn't limit the height, so portrait previews appear much larger than the other previews. |
@WithoutPants Ah right, fixed. |
One more regression: the scene titles don't show up any more, regardless of if the option is enabled. |
@WithoutPants Oof, tried to render the function instead of calling it. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a regression in the wall behaviour where the 15th element (last element on the 3rd row) doesn't move to the correct position. It is getting transform-origin-bottom
when I think it needs to be getting transform-origin-right
.
Ungenerated marker previews are not shown in video and static image modes.
@WithoutPants Good catch, I've fixed the bugs and added a generation message. |
* Add optional image preview generation * Add setting for video preview encoding preset
Adds an option to select either video, animation or image previews for walls. Also adds a setting for preview generation preset.
I've refactored the wall components to largely only use css properties, this has the advantage of being more exact and deterministic. Also fixed a few issues like the gaps between wall items on larger screens, and the flashing when the page loads.
IMO the experience is a lot better since video playback is completely smooth, plus it saves a bunch of time and space from not having to generate webps.