Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bencoder.pyx, update vips #5416

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

feederbox826
Copy link
Contributor

@feederbox826 feederbox826 commented Oct 23, 2024

bencoder

bencoder.pyx can be replaced by drop-in fastbencode stashapp/CommunityScrapers#2077

Originally added in #3273

This removes the need for build dependencies and should cut down on build time #3278 as musl wheels are pre-distributed. Since the build dependencies don't make it into the final image, there is no benefit in keeping them.

vips

reverts #4402, originally from discord

alpine:latest (currently 3.20) is on 8.15.2-r1 which had a relevant bug fixed in 8.15.1 Testing on linux/arm/v6 produces proper thumbnails, MCVE attached

@feederbox826 feederbox826 marked this pull request as draft October 23, 2024 22:45
@feederbox826 feederbox826 changed the title remove bencoder.pyx remove bencoder.pyx, update vips Oct 23, 2024
@feederbox826 feederbox826 marked this pull request as ready for review October 23, 2024 23:39
@WithoutPants WithoutPants added the chore Pull requests for refactoring and admin work label Oct 28, 2024
@WithoutPants WithoutPants added this to the Version 0.28.0 milestone Oct 28, 2024
@WithoutPants WithoutPants merged commit 33ca4f8 into stashapp:develop Oct 28, 2024
2 checks passed
@feederbox826 feederbox826 deleted the fastbencode branch October 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for refactoring and admin work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants