Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localize dates and numbers #574

Merged
merged 5 commits into from
May 25, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 23, 2020

Localizes dates and numbers when not editing. Also changed height rendering to imperial if locale is set to US.

Resolves #565

@WithoutPants
Copy link
Collaborator

The height change is a little contentious:

  • imo input and display should be consistent. Having the US users input in metric and display in imperial seems like a usability issue
  • for those users that have not yet changed there locale away from US to UK (like me), the height is now inexplicably formatted as imperial, with no obvious reason why

IMO, we should defer the height change to a later PR with the following refinements:

  • input should be in the same format as display
  • a changelog entry indicating that for users that have not switched locales, the height field will be changed from previous, and how to resolve the issue
  • the language field in the settings should document the impact on the display - including the height change

@ghost
Copy link
Author

ghost commented May 24, 2020

I removed the feet/inches conversion for now. I considered adding a metric/imperial option, but it seemed overkill when we don't have weight anyway. I have no idea if Americans prefer feet/inches, I assume so, but we can defer it until a later point when it can be implemented in a more thorough fashion.

@ghost ghost changed the title Localize dates, numbers and height Localize dates and numbers May 24, 2020
@WithoutPants WithoutPants merged commit 197918d into stashapp:develop May 25, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Format all numbers and dates
1 participant