Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload scrapers button #592

Merged
merged 7 commits into from
Jun 10, 2020
Merged

Conversation

WithoutPants
Copy link
Collaborator

Adds an entry in the scrapers button to refresh loaded scrapers. This is for when scrapers are modified, added or removed. Changes to the scrapers will not come into effect until the scrapers are reloaded or the system is restarted.

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Jun 3, 2020
@bnkai
Copy link
Collaborator

bnkai commented Jun 4, 2020

I'm having trouble rendering the scrape menu in the scene edit menu.
It doesn't show anything except the save and delete button (the scrape button appears works/ok).
I think QueryableScrapers is empty for some reason.
What are the requirements for a scraper to get added there ?

@WithoutPants
Copy link
Collaborator Author

The scene scraper menu is populated by scrapers that have the sceneByFragment section. See #236 and #269 for examples.

Changed so that the scene scraper menu now always displays for the reload option even if there are no queryable scrapers.

@bnkai
Copy link
Collaborator

bnkai commented Jun 5, 2020

The xpath samples I think didn't have the sceneByFragment so it didn't make it in most ( if not all) of the xpath scene community scrapers. What should be the "action :" part for an xpath scraper? The scraper name?

@WithoutPants
Copy link
Collaborator Author

sceneByFragment doesn't currently support xpath scrapers.

@WithoutPants
Copy link
Collaborator Author

The action field will need to be script or stash.

@bnkai
Copy link
Collaborator

bnkai commented Jun 5, 2020

Works ok for me. Both scene and performer section.

@WithoutPants WithoutPants merged commit d8ce137 into stashapp:develop Jun 10, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add reload scraper option to performer details
* Add scraper reload to scene edit page
* Show scene scraper menu when no queryable scrapers
* Add 0.3 changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants